Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:electron: Fix "Unknown problem opening <local actual file>" on Electron #3220

Merged
merged 38 commits into from
Aug 12, 2024
Merged

:electron: Fix "Unknown problem opening <local actual file>" on Electron #3220

merged 38 commits into from
Aug 12, 2024

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented Aug 8, 2024 •
edited
Loading

Fixes:

Root cause:

  • better-sqlite3 was being built incorrectly.

Solution:

  • Move away from "Universal" builds for now, build for x64 and arm64.
  • Before packing the app, detect which arch we're building for and build better-sqlite3 manually for that arch

@MikesGlitch MikesGlitch changed the title [WIP] Electron/testing - using this to debug the built package - no looking! 👀 [WIP] Electron testing - using this to debug the built package - no looking! 👀 Aug 8, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 8, 2024 •
edited
Loading

✅ Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit f0659a5
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66ba0f7f71d4a6000869ab6f
😎 Deploy Preview https://deploy-preview-3220.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.92 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 27.55 kB 0%
static/js/narrow.js 77.56 kB 0%
static/js/wide.js 246.21 kB 0%
static/js/ReportRouter.js 1.24 MB 0%
static/js/index.js 3.19 MB 0%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.14 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.14 MB 0%

@MikesGlitch MikesGlitch changed the title [WIP] Electron testing - using this to debug the built package - no looking! 👀 [WIP] Electron testing - using this to debug the mac package - no looking! 👀 Aug 8, 2024
@MikesGlitch MikesGlitch changed the title [WIP] Electron testing - using this to debug the mac package - no looking! 👀 :electron: Fix "Unknown problem opening <local actual file>" on Electron Aug 12, 2024
@MikesGlitch MikesGlitch marked this pull request as ready for review August 12, 2024 09:29
@MikesGlitch MikesGlitch mentioned this pull request Aug 12, 2024
Merged
MatissJanis
MatissJanis approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! And CI builds now also produce a working artefact! Thank you so much for looking into this!

@MikesGlitch MikesGlitch merged commit 6f3af7b into actualbudget:master Aug 12, 2024
19 checks passed
@MikesGlitch MikesGlitch deleted the electron/testing branch August 12, 2024 21:50
This was referenced Aug 12, 2024
Closed
Closed
@Kidglove57
Copy link

I have been trying to install the Arm version on my M2 Mac but when I open it I get a “this file is damaged move to bin” error

@MikesGlitch
Copy link
Contributor Author

MikesGlitch commented Aug 14, 2024 •
edited
Loading

I have been trying to install the Arm version on my M2 Mac but when I open it I get a “this file is damaged move to bin” error

This is to do with code signing - we know about it and it wont go away on newer machines until we sign the app. You can get around it by running this:

 xattr -c <path/to/application.app>

I raised an issue for it for visibility: #3259

@Kidglove57
Copy link

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatissJanis MatissJanis MatissJanis approved these changes

Assignees
No one assigned
Labels
✨ Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikesGlitch @Kidglove57 @MatissJanis